Re: [PATCH net-next 4/7] net: phy: marvell10g: Add support for 2.5GBASET and 5GBASET
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Date: 2019-01-18 15:51:20
Also in:
lkml, netdev
On Fri, Jan 18, 2019 at 04:23:49PM +0100, Maxime Chevallier wrote:
quoted hunk ↗ jump to hunk
@@ -264,8 +265,10 @@ static int mv3310_config_init(struct phy_device *phydev) if (ret) return ret; - linkmode_and(phydev->advertising, phydev->advertising, - phydev->supported); + /* Make sure we advertise all the supported modes, and not just the + * default one specified in the driver's .features. + */ + linkmode_copy(phydev->advertising, phydev->supported);
This looks wrong to me, it tramples over the work that phy_probe() did, specifically with regard to the pause mode bits. Please see the comments in that function about the pause mode bits. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel