Thread (51 messages) 51 messages, 5 authors, 2017-06-23

[PATCH v2 04/11] drm: sun4i: add support for H3's TCON0/1

From: icenowy@aosc.io (Icenowy Zheng)
Date: 2017-06-07 11:09:19
Also in: dri-devel, linux-clk, linux-devicetree, lkml


? 2017?6?7? GMT+08:00 ??5:43:43, Maxime Ripard [off-list ref] ??:
On Mon, Jun 05, 2017 at 03:03:47AM +0800, Icenowy Zheng wrote:
quoted
quoted
You should also expand function sun4i_drv_node_is_tcon() at
sun4i_drv.c
quoted
quoted
with 
new entries, but I'm not sure if this fits in this patch.
Instead I think it should be renamed to something like
"sun4i_drv_node_is_tcon_with_ch0".
I'm not sure, or at least, it shouldn't make any difference, since
TCON without a channel 0 will not have an endpoint 0, so this will be
dealt with already.
But that will prevent new coders from add CH1-less TCON
compatibles to this function.
Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help