On 01/04/2017 04:33 AM, Vladimir Zapolskiy wrote:

quoted

+
+	camera: ov5642 at 3c {

ov5642: camera at 3c

done.

quoted

+		pwdn-gpios = <&gpio1 16 GPIO_ACTIVE_HIGH>; /* SD1_DAT0 */
+		reset-gpios = <&gpio1 17 GPIO_ACTIVE_LOW>; /* SD1_DAT1 */

Comments about SD1_* pad names are redundant.

sure, removed.

quoted

+		status = "disabled";

Why is it disabled here?

It's explained in the header. I don't yet have the OV5642 module for
the sabresd for testing, so it is disabled for now.

quoted

+
+	mipi_camera: ov5640 at 3c {

ov5640: camera at 3c

done.

quoted

+		pwdn-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>; /* SD1_DAT2 */
+		reset-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>; /* SD1_CLK */

Comments about SD1_* pad names are redundant.

removed.

quoted

+
+		pinctrl_ipu1_csi0: ipu1grp-csi0 {

Please rename the node name to ipu1csi0grp.

Please add new pin control groups preserving the alphanimerical order.

done and done.


Steve