Thread (37 messages) 37 messages, 3 authors, 2017-01-07

[PATCH v2 05/19] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

From: festevam@gmail.com (Fabio Estevam)
Date: 2017-01-04 15:26:32
Also in: linux-devicetree, linux-media, lkml

On Tue, Jan 3, 2017 at 6:57 PM, Steve Longerbeam [off-list ref] wrote:
+       camera: ov5642 at 3c {
+               compatible = "ovti,ov5642";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_ov5642>;
+               clocks = <&clks IMX6QDL_CLK_CKO>;
+               clock-names = "xclk";
+               reg = <0x3c>;
+               xclk = <24000000>;
+               DOVDD-supply = <&vgen4_reg>; /* 1.8v */
+               AVDD-supply = <&vgen5_reg>;  /* 2.8v, rev C board is VGEN3
+                                               rev B board is VGEN5 */
Please use vgen3 so that by default we have the valid AVDD-supply for
revC boards which is more recent and more the users have access to.
+       mipi_camera: ov5640 at 3c {
+               compatible = "ovti,ov5640_mipi";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_ov5640>;
+               reg = <0x3c>;
+               clocks = <&clks IMX6QDL_CLK_CKO>;
+               clock-names = "xclk";
+               xclk = <24000000>;
+               DOVDD-supply = <&vgen4_reg>; /* 1.8v */
+               AVDD-supply = <&vgen5_reg>;  /* 2.8v, rev C board is VGEN3
+                                               rev B board is VGEN5 */
Same here.
+               pinctrl_ov5640: ov5640grp {
+                       fsl,pins = <
+                               MX6QDL_PAD_SD1_DAT2__GPIO1_IO19 0x80000000
+                               MX6QDL_PAD_SD1_CLK__GPIO1_IO20  0x80000000
Please avoid all the 0x80000000 IOMUX settings and replace them by
their real values.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help