On 4 April 2016 at 13:16, Rob Herring [off-list ref] wrote:

On Sat, Apr 02, 2016 at 05:29:41PM +0800, Guodong Xu wrote:

quoted

From: Chen Feng <redacted>

Add the mfd hi655x dts node and regulator support on
hi6220 platform.

Signed-off-by: Chen Feng <redacted>
Signed-off-by: Fei Wang <redacted>
Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Reviewed-by: Haojian Zhuang <haojian.zhuang@linaro.org>
Reviewed-by: Guodong Xu <redacted>
---
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 87 ++++++++++++++++++++++++++
 1 file changed, 87 insertions(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index 28bc646..a6dffa8 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts

@@ -6,6 +6,7 @@
  */

 /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>

 #include "hi6220.dtsi"
 #include "hikey-gpio.dtsi"

@@ -104,6 +105,92 @@
                      default-state = "off";
              };
      };
+
+     pmic: pmic at f8000000 {
+             compatible = "hisilicon,hi655x-pmic";
+             reg = <0x0 0xf8000000 0x0 0x1000>;
+             interrupt-controller;
+             #interrupt-cells = <2>;
+             pmic-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+             status = "okay";
+
+             regulators {
+                     ldo2: LDO2 at a21 {

@a21 is not a unit address. Please drop these.

Will change these to
 +                     ldo2: LDO2 {
...
 +                     ldo7: LDO7 {
...

Thanks for review, Rob.

-Guodong

quoted

+                             regulator-name = "LDO2_2V8";
+                             regulator-min-microvolt = <2500000>;
+                             regulator-max-microvolt = <3200000>;
+                             regulator-enable-ramp-delay = <120>;
+                     };
+
+                     ldo7: LDO7 at a26 {