Thread (34 messages) 34 messages, 5 authors, 2016-04-12

[PATCH v2 13/16] arm64: dts: add LED nodes for hi6220-hikey

From: robh@kernel.org (Rob Herring)
Date: 2016-04-04 05:16:57
Also in: linux-devicetree, lkml

On Sat, Apr 02, 2016 at 05:29:40PM +0800, Guodong Xu wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Guodong Xu <redacted>
---
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 41 ++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
index c4f560a..28bc646 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
+++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
@@ -63,6 +63,47 @@
 			status = "ok";
 		};
 	};
+
+	leds {
+		compatible = "gpio-leds";
+		user_led4 {
Don't use underscores in node names: user-led4
+			label = "user_led4";
We need to make sure the node names and labels are aligned with other 
boards. There's some discussion about this for the new db600 board.

This looks closer to what we should have than what we have for 
db410c currently.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help