Thread (34 messages) 34 messages, 5 authors, 2016-04-12

[PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220

From: Leo Yan <hidden>
Date: 2016-04-04 14:04:07
Also in: linux-devicetree, lkml

On Mon, Apr 04, 2016 at 03:53:47PM +0200, Linus Walleij wrote:
On Mon, Apr 4, 2016 at 3:42 PM, Leo Yan [off-list ref] wrote:
quoted
On Mon, Apr 04, 2016 at 01:21:00PM +0200, Linus Walleij wrote:
[...]
quoted
Also have checked Hi6220's spec, there have no timer's dediated clock
enabling bits. This is the reason before I only registered one clock.
So according to you and Rob's comments, how about change as below?

                dual_timer0: timer at f8008000 {
                        compatible = "arm,sp804", "arm,primecell";
                        reg = <0x0 0xf8008000 0x0 0x1000>;
                        interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
                                     <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
                        clocks = <&ao_ctrl HI6220_TIMER0_PCLK>,
                                 <&ao_ctrl HI6220_TIMER0_PCLK>,
                                 <&ao_ctrl HI6220_TIMER0_PCLK>;
                        clock-names = "apb_pclk", "apb_pclk", "apb_pclk";
This works for me, though I think only the last name
matters so I would name the first two "timer1" and "timer2".
Will fix to "timer1" and "timer2" and sent out new patch.

Thanks,
Leo Yan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help