On 12.10.2015 09:37, Yakir Yang wrote:

Hi Krzysztof,

On 10/10/2015 11:46 PM, Yakir Yang wrote:

quoted

Both hsync/vsync polarity and interlace mode can be parsed from
drm display mode, and dynamic_range and ycbcr_coeff can be judge
by the video code.

But presumably Exynos still relies on the DT properties, so take
good use of mode_fixup() in to achieve the compatibility hacks.

Signed-off-by: Yakir Yang <redacted>
---
Changes in v6: None

+    of_property_read_u32(dp_node, "hsync-active-high",
+                 &video->h_sync_polarity);
+    of_property_read_u32(dp_node, "vsync-active-high",
+                 &video->v_sync_polarity);
+    of_property_read_u32(dp_node, "interlaced",
+                 &video->interlaced);
+}


Sorry, forget to fix your previous comment here, would
remember to fix it to v7 version, wish v6 would collect
more comment/reviewed/ack.  :)

Right.

You can send a v7 of only this patch.

In the same time I would prefer not to chain-reply next version of
entire patchset to cover letter of previous version. It confuses me
because v6 appears UNDER v4 so I can't really find v6. I see v4 at the
top of my email list.

In the same time the patchset is quite big. Put the latest version (with
this issue above fixed!) on some repo and link it in cover letter.

Best regards,
Krzysztof

Best regards,
- Yakir

quoted

Changes in v5:
- Switch video timing type to "u32", so driver could use
"of_property_read_u32"
   to get the backword timing values. Krzysztof suggest me that driver
could use
   the "of_property_read_bool" to get backword timing values, but that
interfacs
   would modify the original drm_display_mode timing directly (whether
those
   properties exists or not).

Changes in v4:
- Provide backword compatibility with samsung. (Krzysztof)

Changes in v3:
- Dynamic parse video timing info from struct drm_display_mode and
   struct drm_display_info. (Thierry)

Changes in v2: None