Hi Krzysztof,

On 09/30/2015 01:22 PM, Krzysztof Kozlowski wrote:

On 22.09.2015 16:34, Yakir Yang wrote:

quoted

Fix some obvious alignment problems, like alignment and line
over 80 characters problems, make this easy to be maintained
later.

Signed-off-by: Yakir Yang <redacted>
---
Changes in v5:
- Resequence this patch after analogix_dp driver have been split
   from exynos_dp code, and rephrase reasonable commit message, and
   remove some controversial style (Krzysztof)
     -		analogix_dp_write_byte_to_dpcd(
     - 				dp, DP_TEST_RESPONSE,
     +		analogix_dp_write_byte_to_dpcd(dp,
     +				DP_TEST_RESPONSE,
				DP_TEST_EDID_CHECKSUM_WRITE);

Changes in v4: None
Changes in v3: None
Changes in v2:
- Improved commit message more readable, and avoid using some
   uncommon style like bellow: (Joe Preches)
     -  retval = exynos_dp_read_bytes_from_i2c(...
   				  ...);
     +  retval =
     +  exynos_dp_read_bytes_from_i2c(......);

  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 129 ++++++++++-----------
  drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |  72 ++++++------
  drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c  | 124 ++++++++++----------
  3 files changed, 163 insertions(+), 162 deletions(-)

IMHO much better than in previous attempt. The code looks good:

Reviewed-by: Krzysztof Kozlowski <redacted>

BTW my opinion is not enough, you still need an ack from Exynos DP
maintainer (or DRM guys).

Aha, thanks.

- Yakir

Best regards,
Krzysztof