Thread (19 messages) 19 messages, 8 authors, 2015-08-18
STALE3976d
Revisions (6)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v1 current
  5. v1 [diff vs current]
  6. v1 [diff vs current]

[PATCH 2/3] Display a DMA error message

From: arnd@arndb.de (Arnd Bergmann)
Date: 2015-08-14 21:19:46
Also in: linux-acpi

On Wednesday 12 August 2015 16:51:29 Jeremy Linton wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index 2593def..82e396f 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -162,8 +162,10 @@ static int ehci_platform_probe(struct platform_device *dev)
 
        err = dma_coerce_mask_and_coherent(&dev->dev,
                pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32));
-       if (err)
+       if (err) {
+               dev_err(&dev->dev, "Error: DMA setup failed\n");
                return err;
+       }
We should really stop doing this: the platform should provide the
correct dma mask when creating the device, instead of setting a
bogus pdata field. Do not duplicate this bug for ACPI.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help