[PATCH 3/3] Add ACPI bindings for the EHCI platform driver.
From: guohanjun@huawei.com (Hanjun Guo)
Date: 2015-08-13 11:50:08
Also in:
linux-acpi
Hi Jeremy, Just minor comments below. (resend as it's blocked by mailist) On 2015/8/13 5:51, Jeremy Linton wrote:
quoted hunk ↗ jump to hunk
This enables USB on the ARM juno board when booted with an ACPI kernel. The PNP id comes from the PNP/ACPI registry and describes a EHCI controller without debug. Signed-off-by: Jeremy Linton <redacted> --- drivers/usb/host/ehci-platform.c | 9 +++++++++ 1 file changed, 9 insertions(+)diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index 82e396f..1807baa 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c@@ -27,6 +27,7 @@ #include <linux/io.h> #include <linux/module.h> #include <linux/of.h> +#include <linux/acpi.h>
this file list the head file in alphabetical order, I think it's better to follow that rule.
quoted hunk ↗ jump to hunk
#include <linux/phy/phy.h> #include <linux/platform_device.h> #include <linux/reset.h>@@ -382,6 +383,13 @@ static const struct of_device_id vt8500_ehci_ids[] = { }; MODULE_DEVICE_TABLE(of, vt8500_ehci_ids); +static const struct acpi_device_id ehci_acpi_match[] = { + { "PNP0D20", 0 }, + { } +}; +MODULE_DEVICE_TABLE(acpi, ehci_acpi_match); + +
Single empty line will be fine :)
quoted hunk ↗ jump to hunk
static const struct platform_device_id ehci_platform_table[] = { { "ehci-platform", 0 }, { }@@ -400,6 +408,7 @@ static struct platform_driver ehci_platform_driver = { .name = "ehci-platform", .pm = &ehci_platform_pm_ops, .of_match_table = vt8500_ehci_ids, + .acpi_match_table = ACPI_PTR(ehci_acpi_match), } };
With that minor fixes, Reviewed-by: Hanjun Guo <redacted> Thanks Hanjun