[PATCH 2/3] Display a DMA error message
From: stern@rowland.harvard.edu (Alan Stern)
Date: 2015-08-13 14:52:56
Also in:
linux-acpi
On Wed, 12 Aug 2015, Jeremy Linton wrote:
quoted hunk ↗ jump to hunk
If the ehci driver fails to configure the dma settings then display a dev error instead of simply failing. This is triggered in an ACPI world if the user fails to set the _CCA on the device. Signed-off-by: Jeremy Linton <redacted> --- drivers/usb/host/ehci-platform.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index 2593def..82e396f 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c@@ -162,8 +162,10 @@ static int ehci_platform_probe(struct platform_device *dev) err = dma_coerce_mask_and_coherent(&dev->dev, pdata->dma_mask_64 ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32)); - if (err) + if (err) { + dev_err(&dev->dev, "Error: DMA setup failed\n"); return err; + } irq = platform_get_irq(dev, 0); if (irq < 0) {
Too bad the ohci-platform driver doesn't get the same update, but it clearly wouldn't belong in this patch set. Anyway, Acked-by: Alan Stern <stern@rowland.harvard.edu> Alan Stern