Thread (153 messages) 153 messages, 15 authors, 2015-06-24

[PATCH v4 04/10] eeprom: Add a simple EEPROM framework for eeprom consumers

From: broonie@kernel.org (Mark Brown)
Date: 2015-05-06 17:29:21
Also in: linux-api, linux-arm-msm, linux-devicetree, lkml

On Mon, Mar 30, 2015 at 10:57:50PM +0100, Srinivas Kandagatla wrote:
+
+	for (i = 0; i < cell->nblocks; i++) {
+		rc = regmap_raw_read(eeprom->regmap, cell->blocks[i].offset,
+				      buf + offset, cell->blocks[i].count);
I *think* this is probably OK but please double check that the count
here is in bytes rather than words, it's a bit confusing since I'd read
a count as being in words.  Otherwise I think the regmap usage here all
looks good.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150506/99a5b6e6/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help