On Tue, 2015-03-24 at 23:05 +0000, Srinivas Kandagatla wrote:

On 24/03/15 22:36, Mark Brown wrote:

quoted

quoted

+int regmap_get_max_register(struct regmap *map)
+{
+	return map->max_register ? : -EINVAL;
+}

Please write the logic out properly, don't abuse the ternery operator.

Am happy to change it to your preference in next version, but this GNU 
extensions widely used in the kernel

$  grep -rR "return.*? :" ./linux | wc -l
115

Double that when you add the ?: variants

$ git grep -E "return.*\?\s*:" | wc -l
253

There are ~530 uses like:

	return <foo> ? <foo> :