Thread (20 messages) 20 messages, 4 authors, 2015-02-20

[PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

From: Mike Turquette <hidden>
Date: 2015-02-03 21:08:56
Also in: lkml

Quoting Fabio Estevam (2015-01-30 11:28:32)
On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren [off-list ref] wrote:
quoted
According to i.MX23 and i.MX28 reference manual [1],[2] the fractional
clock control register is 32-bit wide, but is separated in 4 parts.
So write instructions must not apply to more than 1 part at once.

The clk init for the i.MX28 violates this restriction and all the other
accesses on that register suggest that there isn't such a restriction.

This patch restricts the access to this register to byte instructions and
extends the comment in the init functions.

Btw the imx23 init now uses a R-M-W sequence just like imx28 init
to avoid any clock glitches.

The changes has been tested with a i.MX23 and a i.MX28 board.

[1] - http://cache.freescale.com/files/dsp/doc/ref_manual/IMX23RM.pdf
[2] - http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf

Signed-off-by: Stefan Wahren <redacted>
Reviewed-by: Marek Vasut <marex@denx.de>
Reviewed-by: Fabio Estevam <redacted>
Applied to clk-next.

Thanks,
Mike
Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help