[PATCH] gpio: mxs: implement get_direction callback

2014-11-17 15:29 GMT+01:00 Janusz U?ycki [off-list ref]:

Hi Richard,

W dniu 2014-11-17 o 11:05, Richard Genoud pisze:

quoted

2014-11-17 10:59 GMT+01:00 Uwe Kleine-K?nig
[off-list ref]:

well, in this case, request_irq() will fail and all the previously
requested irqs will be freed:
     /*
      * If something went wrong, rollback.
      */
     while (err && (--i >= 0))
         if (irq[i] >= 0)
             free_irq(irq[i], port);

I hesitate if use the rollback or just call mctrl_gpio_free_irqs().
Let's note that "i" is enum and the loop ends on i < 0.

That's right, it's a bug.
I thought that enum was signed, but actually, it could be unsigned on
some platforms.