Thread (41 messages) 41 messages, 5 authors, 2014-11-18

[PATCH] gpio: mxs: implement get_direction callback

From: Janusz Użycki <hidden>
Date: 2014-11-17 14:29:24
Also in: linux-gpio, linux-serial

Hi Richard,

W dniu 2014-11-17 o 11:05, Richard Genoud pisze:
2014-11-17 10:59 GMT+01:00 Uwe Kleine-K?nig [off-list ref]:

well, in this case, request_irq() will fail and all the previously
requested irqs will be freed:
     /*
      * If something went wrong, rollback.
      */
     while (err && (--i >= 0))
         if (irq[i] >= 0)
             free_irq(irq[i], port);
I hesitate if use the rollback or just call mctrl_gpio_free_irqs().
Let's note that "i" is enum and the loop ends on i < 0.

best regards
Janusz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help