Thread (41 messages) 41 messages, 5 authors, 2014-11-18

[PATCH] gpio: mxs: implement get_direction callback

From: Uwe Kleine-König <hidden>
Date: 2014-11-17 15:59:30
Also in: linux-gpio, linux-serial

On Mon, Nov 17, 2014 at 03:45:00PM +0100, Janusz U?ycki wrote:
W dniu 2014-11-17 o 10:26, Richard Genoud pisze:
quoted
And, honestly, I'm not sure dev_name(dev) is a good name.
Having something like dev_name(dev)_port_id_CTS may be better.
For names other than device's or driver's name I would need to allocate
string. Is it so important? You can simple check the interrupt and
corresponding port:
cat /proc/interrupts
 50:          0  gpio-mxs  21  80072000.serial
 80:          0  gpio-mxs  18  8006c000.serial
 81:          0  gpio-mxs  19  8006c000.serial
 83:          0  gpio-mxs  21  8006c000.serial
 84:          0  gpio-mxs  22  8006c000.serial
I'd say this is good enough.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help