[linux-sunxi] Re: [PATCH 4/4] simplefb: add clock handling code
From: broonie@kernel.org (Mark Brown)
Date: 2014-09-29 15:55:17
Also in:
linux-fbdev
On Mon, Sep 29, 2014 at 03:47:15PM +0200, Thierry Reding wrote:
What happened in the Snow example is that regulators that were previously on would all of a sudden be automatically disabled on boot because there was now a driver that registered them with a generic framework.
Not quite - there was also DT added for them. With just the driver the regulator API shouldn't have touched them, it'd just have exposed them read only.
The same thing is going to happen with simplefb for your device. If you later realize that you need a regulator to keep the panel going, you'll have to add code to your firmware to populate the corresponding properties, otherwise the regulator will end up unused and will be automatically disabled. At the same time you're going to break upstream for all users of your old firmware because it doesn't add that property yet.
And the same will continue to happen for every new type of resource you're going to add.
So long as we're ensuring that when we don't start supporting resources without DT additions or at least require DT additions to actively manage them (which can then include simplefb hookup) we should be fine.
quoted
quoted
The difference is that with the solution I proposed we don't have to keep track of all the resources. We know that firmware has set them up and we know that a real driver will properly take them over at some point
quoted
You keep saying that... and you know that you can't make this assumption.
Why not? Are you really expecting to keep running with simplefb forever? Nobody is going to seriously use an upstream kernel in any product with only simplefb as a framebuffer. I've said before that this is a hack to get you working display. And that's all it is. If you want to do it properly go and write a DRM/KMS driver.
Well, for product probably not. But in terms of the runtime of a kernel I'd not be so sure - people do dogfood and we should be allowing that. I've used unaccelerated displays with reasonable success for a large part of my work in the past. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140929/946d1de9/attachment.sig>