[PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi

Hello Tushar,

Thanks a lot for your feedback.

On 07/02/2014 11:20 AM, Tushar Behera wrote:

On 06/26/2014 11:45 PM, Javier Martinez Canillas wrote:

quoted

Peach pit and pi boards uses a Maxim 77802 power management
IC to drive regulators and its Real Time Clock. This patch
adds support for this chip.

These are the device nodes and pinctrl configuration that
are present on the Peach pit DeviceTree source file in the
the Chrome OS kernel 3.8 tree.

Signed-off-by: Javier Martinez Canillas <redacted>
Tested-by: Naveen Krishna Chatradhi <redacted>
---

[ ... ]

quoted

+
+		regulators {
+			buck1_reg: BUCK1 {
+				regulator-name = "vdd_mif";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <1300000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-ramp-delay = <12500>;
+			};

IMO, adding a blank line between sub-nodes would be better.

Ok

quoted

+			buck2_reg: BUCK2 {
+				regulator-name = "vdd_arm_real";
+				regulator-min-microvolt = <800000>;
+				regulator-max-microvolt = <1500000>;
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-ramp-delay = <12500>;
+			};

[ ... ]

quoted

+			vqmmc_sdcard: ldo4_reg: LDO4 {
+				regulator-name = "vdd_sd";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <2800000>;
+				regulator-always-on;
+

Blank line, can be removed.

Ok

quoted

+			};

[ ... ]

quoted

+			ldo23_reg: LDO23 {
+				regulator-name = "ld0_23";

ldo_23, 'o' in place of '0'.

Right, missed that. Thanks for pointing out.

Similar comments for peach-pi DTS file.

Best regards,
Javier