[PATCH 12/12] ARM: OMAP2xxx: PM: add pwrdm_(pre|post)_transition() calls to... | linux-arm-kernel

[PATCH 00/12] ARM: OMAP2+: powerdomain updates after the functional power state conversion · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 01/12] ARM: OMAP2+: powerdomain: consolidate arch_pwrdm check code · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 02/12] ARM: OMAP2+: PM/powerdomain: move the power state time tracking into the powerdomain code · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 03/12] ARM: OMAP2+: powerdomain: split pwrdm_state_switch() · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 04/12] ARM: OMAP2+: PM: clean up some debugfs functions · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 06/12] ARM: OMAP2+: CM: use the cached copy of the clockdomain's hwsup state · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 07/12] ARM: OMAP2+: powerdomain: cache the powerdomain next power state · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 08/12] ARM: OMAP2+: powerdomain: cache the powerdomain's previous power state · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on · Vaibhav Hiremath <hidden> · 2012-12-12
[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on · Jon Hunter <hidden> · 2012-12-19
[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on · paul@pwsan.com (Paul Walmsley) · 2012-12-20
[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on · Santosh Shilimkar <hidden> · 2012-12-21
[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on · Bedia, Vaibhav <hidden> · 2012-12-26
[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on · Bedia, Vaibhav <hidden> · 2012-12-26
[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on · paul@pwsan.com (Paul Walmsley) · 2012-12-26
[PATCH 10/12] ARM: OMAP2+: powerdomain: skip previous-power-state read if next_pwrst is ON · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 11/12] ARM: OMAP2xxx: powerdomain: add previous power state tracking · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 12/12] ARM: OMAP2xxx: PM: add pwrdm_(pre|post)_transition() calls to the 2xxx PM code · paul@pwsan.com (Paul Walmsley) · 2012-12-09
[PATCH 00/12] ARM: OMAP2+: powerdomain updates after the functional power state conversion · Tero Kristo <hidden> · 2013-01-04

STALE4930d

[PATCH 12/12] ARM: OMAP2xxx: PM: add pwrdm_(pre|post)_transition() calls to the 2xxx PM code

From: paul@pwsan.com (Paul Walmsley)
Date: 2012-12-09 20:03:33
Also in: linux-omap
Subsystem: arm port, omap power management support, omap2+ support, the rest · Maintainers: Russell King, Kevin Hilman, Aaro Koskinen, Andreas Kemnade, Roger Quadros, Tony Lindgren, Linus Torvalds

The OMAP2xxx PM code was missing calls to pwrdm_pre_transition() and
pwrdm_post_transition().  This prevented the power state debugging
from working correctly, and also violated some assumptions that are
used in future power state caching patches.

Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Kevin Hilman <redacted>
---
 arch/arm/mach-omap2/pm24xx.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/mach-omap2/pm24xx.c b/arch/arm/mach-omap2/pm24xx.c
index 99c16c2..896727c 100644
--- a/arch/arm/mach-omap2/pm24xx.c
+++ b/arch/arm/mach-omap2/pm24xx.c

@@ -98,6 +98,8 @@ static int omap2_enter_full_retention(void)
 
 	omap2_gpio_prepare_for_idle(0);
 
+	pwrdm_pre_transition(NULL);
+
 	/* One last check for pending IRQs to avoid extra latency due
 	 * to sleeping unnecessarily. */
 	if (omap_irq_pending())

@@ -109,6 +111,8 @@ static int omap2_enter_full_retention(void)
 			   OMAP_SDRC_REGADDR(SDRC_POWER));
 
 no_sleep:
+	pwrdm_post_transition(NULL);
+
 	omap2_gpio_resume_after_idle();
 
 	clk_enable(osc_ck);

@@ -191,8 +195,12 @@ static void omap2_enter_mpu_retention(void)
 		WARN_ON(pwrdm_set_next_fpwrst(mpu_pwrdm, PWRDM_FUNC_PWRST_ON));
 	}
 
+	pwrdm_pre_transition(mpu_pwrdm);
+
 	omap2_sram_idle();
 
+	pwrdm_post_transition(mpu_pwrdm);
+
 	WARN_ON(pwrdm_set_next_fpwrst(mpu_pwrdm, PWRDM_FUNC_PWRST_ON));
 }

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help