Thread (6 messages) flat view 6 messages, 3 authors, 2012-11-15

Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout

From: Wolfram Sang <hidden>
Date: 2012-11-15 09:30:06
Also in: linux-i2c, lkml

quoted
-       if (timeout < 0) {
-               dev_err(&dev->adev->dev,
-                       "wait_for_completion_timeout "
-                       "returned %d waiting for event\n", timeout);
-               status = timeout;
-       }
-
No, it is wrong. You need to update the status variable in the case of timeout.
Looking at the patch context, such code comes later.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20121115/f7edc23a/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help