Fwd: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
From: Srinidhi Kasagar <hidden>
Date: 2012-11-15 08:50:42
Also in:
linux-i2c, lkml
[...]
quoted hunk
From: Chuansheng Liu <redacted> Date: Tue, Nov 6, 2012 at 6:18 PM Subject: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout To: linus.walleij at linaro.org, w.sang at pengutronix.de Cc: linux-arm-kernel at lists.infradead.org, linux-kernel at vger.kernel.org, chuansheng.liu at intel.com The return value of wait_for_completion_timeout() is alwaysquoted
= 0 with unsigned int type.So the condition "ret < 0" or "ret >= 0" is pointless. Signed-off-by: liu chuansheng <redacted> --- drivers/i2c/busses/i2c-nomadik.c | 14 -------------- 1 files changed, 0 insertions(+), 14 deletions(-)diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index 02c3115..8b2ffcf 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c@@ -435,13 +435,6 @@ static int read_i2c(struct nmk_i2c_dev *dev, u16 flags) timeout = wait_for_completion_timeout( &dev->xfer_complete, dev->adap.timeout); - if (timeout < 0) { - dev_err(&dev->adev->dev, - "wait_for_completion_timeout " - "returned %d waiting for event\n", timeout); - status = timeout; - } -
No, it is wrong. You need to update the status variable in the case of timeout.
It is used further in nmk_i2c_xfer_one. You could perhaps use
if (timeout == 0) {
...and the rest of the code as is
}
regards/srinidhi