From: Chuansheng Liu <redacted>
Date: Tue, Nov 6, 2012 at 6:18 PM
Subject: [PATCH 1/7] I2c-nomadik: Fix the usage of wait_for_completion_timeout
To: linus.walleij at linaro.org, w.sang at pengutronix.de
Cc: linux-arm-kernel at lists.infradead.org,
linux-kernel at vger.kernel.org, chuansheng.liu at intel.com
The return value of wait_for_completion_timeout() is always
quoted
= 0 with unsigned int type.
So the condition "ret < 0" or "ret >= 0" is pointless.
Signed-off-by: liu chuansheng <redacted>
---
drivers/i2c/busses/i2c-nomadik.c | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
@@ -435,13 +435,6 @@ static int read_i2c(struct nmk_i2c_dev *dev, u16 flags)timeout=wait_for_completion_timeout(&dev->xfer_complete,dev->adap.timeout);-if(timeout<0){-dev_err(&dev->adev->dev,-"wait_for_completion_timeout "-"returned %d waiting for event\n",timeout);-status=timeout;-}-
No, it is wrong. You need to update the status variable in the case of timeout.
It is used further in nmk_i2c_xfer_one. You could perhaps use
if (timeout == 0) {
...and the rest of the code as is
}
regards/srinidhi
From: Chuansheng Liu <hidden> Date: 2012-11-15 10:52:36
timeout is never < 0, so status = timeout is never getting run. This patch delete pointless
code. Could you show the regression? Thanks.
? 2012-11-15?17:57?Srinidhi Kasagar [off-list ref] ???
On Thu, Nov 15, 2012 at 10:29:53 +0100, Wolfram Sang wrote:
quoted
quoted
quoted
- if (timeout < 0) {
- dev_err(&dev->adev->dev,
- "wait_for_completion_timeout "
- "returned %d waiting for event\n", timeout);
- status = timeout;
- }
-
No, it is wrong. You need to update the status variable in the case of timeout.
Looking at the patch context, such code comes later.
But it causes regressions; without looking at the "later" code, we can't afford merging
this code now.
regards/srinidhi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/