[PATCH 01/24] ARM: shmobile: use __iomem pointers for MMIO
From: Paul Mundt <hidden>
Date: 2012-09-18 07:43:10
Also in:
linux-sh, lkml
On Fri, Sep 14, 2012 at 11:34:29PM +0200, Arnd Bergmann wrote:
ARM is moving to stricter checks on readl/write functions, so we need to use the correct types everywhere. This patch is a bit ugly for shmobile, which is the only platform that just uses integer literals all over the place, but I can't see a better way to do this.
If you want to crap up the ARM side with this stuff, that's fine, but leave sh-sci out of it. So, NAK on this part:
quoted hunk ↗ jump to hunk
diff --git a/include/linux/serial_sci.h b/include/linux/serial_sci.h index eb763ad..d323290 100644 --- a/include/linux/serial_sci.h +++ b/include/linux/serial_sci.h@@ -150,7 +150,7 @@ struct plat_sci_port { int overrun_bit; unsigned int error_mask; - int port_reg; + void __iomem *port_reg; unsigned char regshift; unsigned char regtype;
but I don't mind if you cast the callsite in drivers/tty/serial/sh-sci.c