[PATCH 05/24] ARM: imx: use __iomem pointers for MMIO
From: festevam@gmail.com (Fabio Estevam)
Date: 2012-09-14 22:31:49
Also in:
lkml
On Fri, Sep 14, 2012 at 6:34 PM, Arnd Bergmann [off-list ref] wrote:
ARM is moving to stricter checks on readl/write functions, so we need to use the correct types everywhere. This found a bug in mach-armadillo5x0.c, where we attempt mmio on the MXC_CCM_RCSR address that is currently defined to 0xc and consequently causes an illegal address access.
...
/* set NAND page size to 2k if not configured via boot mode pins */ - __raw_writel(__raw_readl(MXC_CCM_RCSR) | (1 << 30), MXC_CCM_RCSR); + /* FIXME __raw_writel(__raw_readl(MXC_CCM_RCSR) | (1 << 30), MXC_CCM_RCSR); */
Good catch, the correct access would be: __raw_readl(mx3_ccm_base + MXC_CCM_RCSR) ... I will fix this after your series reaches linux-next. Regards, Fabio Estevam