Thread (67 messages) 67 messages, 17 authors, 2012-09-28

[PATCH 17/24] ARM: OMAP: use __iomem pointers for MMIO

From: tony@atomide.com (Tony Lindgren)
Date: 2012-09-17 21:25:14
Also in: lkml

* Tony Lindgren [off-list ref] [120916 13:39]:
* Arnd Bergmann [off-list ref] [120915 13:15]:
quoted
On Saturday 15 September 2012, Tony Lindgren wrote:
quoted
With my patches, this is now all omap1 specific and
moved to arch/arm/mach-omap1/include/mach/hardware.h.
It's probably easiest to just update this patch on
top of the hardware.h changes I've done.
Yes, sounds good. Do you want to send a patch for that
and let me drop this one then?
Yes I can pick this one and update it against one of my
branches to avoid merge conflicts.
This applies against mach-omap1/include/mach/hardware.h
with some fuzz so no issues there.

But I think we should not apply it as these are physical
addresses, not virtual addresses for omap1.

We have IOMEM already in use for omap_read/write because of:

#define OMAP1_IO_ADDRESS(pa)	IOMEM((pa) - OMAP1_IO_OFFSET)

I think the right solution is to eventually get rid of
omap_read/write for omap1 also and replace them with ioremap
+ readl/writel.

Or am I missing something?

Regards,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help