On Tuesday 10 July 2012 09:12 PM, Mark Brown wrote:

* PGP Signed by an unknown key

On Tue, Jul 10, 2012 at 08:34:24PM +0530, Laxman Dewangan wrote:

quoted

The sample code for tps65910 is as follows. So where do you think
that it is wrong and what should be correct approach.
I need to follow the same for tps6586x also.

Like I said the use of a supply name should be unconditional, you should
just set the supply name in the descriptor.

if I set the desc.supply_name unconditional then if the entry of that 
supply name is not there in the DT entry (on device node) then that 
regulator will not get registered because the search for 
supply_regulator will fail during registration.

I am setting the desc.supply only when there is supply entry in DT or if 
it is from platform.

Do we need to make such supply pin entry as required inplace of optional?