On Tuesday 10 July 2012 07:23 PM, Mark Brown wrote:

* PGP Signed by an unknown key

On Tue, Jul 10, 2012 at 07:14:53PM +0530, Laxman Dewangan wrote:

quoted

Sorry, I did not get it fully. I had two patches, one for fixed one
and other for tps65910. On which patch, you are seeing issue and
which part of code?

Mainly tps65910.  The fixed voltage regulator does have the same issue
but it is somewhat special here.

Oops, I follow the same approach for tps65910 what it was with fixed 
regulator, was thinking that this is good approach.

The sample code for tps65910 is as follows. So where do you think that 
it is wrong and what should be correct approach.
I need to follow the same for tps6586x also.

@@ -1023,6 +1051,13 @@ static struct tps65910_board 

*tps65910_parse_dt_reg_data(
                  "ti,regulator-ext-sleep-control", &prop);
          if (!ret)
              pmic_plat_data->regulator_ext_sleep_control[idx] = prop;
+
+
+        if (info->vin_name) {
+            snprintf(in_supply, 32, "%s-supply", info->vin_name);
+            if (of_find_property(np, in_supply, 0))
+                pmic_plat_data->input_supply[idx] =
+                                info->vin_name;
+        }
      }

      return pmic_plat_data;

@@ -1126,6 +1161,7 @@ static __devinit int tps65910_probe(struct 

platform_device *pdev)
          pmic->info[i] = info;

          pmic->desc[i].name = info->name;
+        pmic->desc[i].supply_name = pmic_plat_data->input_supply[i];
          pmic->desc[i].id = i;