[PATCH 3/3] ARM: dt: tegra: paz00: add regulators
From: Mark Brown <hidden>
Date: 2012-06-24 11:03:06
Also in:
linux-tegra
On Sat, Jun 23, 2012 at 06:35:01PM +0200, Marc Dietrich wrote:
quoted
The regulator configurations were all taken from the AC100 kernel used by the Ubuntu port, specifically:
These generally all look pretty broken...
quoted
+ regulator at 0 { + reg = <0>; + regulator-compatible = "sm0"; + regulator-name = "+1.2vs_sm0"; + regulator-min-microvolt = < 725000>; + regulator-max-microvolt = <1300000>;
Most of these ranges look suspiciously like the maximum possible variation the regulator has, not what the board actually requires (which is a depressingly common error, I've no idea why people seem to think they're supposed to cut'n'paste the physical limits of the regualtor out of the driver). If something decides to take advantage of the variation this could be problematic.
quoted
+ regulator at 3 { + reg = <3>; + regulator-compatible = "ldo0"; + regulator-name = "+3.3vs_ldo0"; + regulator-min-microvolt = <1250000>;
I think the common sense was that this should also be 3.3 V as it is the pex clock (which is not used at all on this board). I guess it doesn't matter much. So ...
Acked-By: Marc Dietrich <marvin24@gmx.de>
quoted
+ regulator-max-microvolt = <3300000>;
This is one example, it looks like the rail needs to be fixed to 3.3V.