[PATCH 1/1] mfd: Fix runtime warning caused by duplicate device registration

On 03/07/12 15:21, Mark Brown wrote:

On Tue, Jul 03, 2012 at 02:48:29PM +0100, Lee Jones wrote:

quoted

On 03/07/12 14:24, Mark Brown wrote:

quoted

quoted

I'm really unconvinced that instnatiating the MFD cells from device tree
is in general a good idea.

quoted

Well it just doesn't work the other way.

In what way does it not work?

quoted

quoted

quoted

See c5395e7ed8f16cc7bb72a783de68659db5aed515 for a short description
of the troubles we faced.

quoted

quoted

$ git show c5395e7ed8f16cc7bb72a783de68659db5aed515
fatal: bad object c5395e7ed8f16cc7bb72a783de68659db5aed515

quoted

Sorry, looks live I've rebased since.

quoted

5f3fc8adeec9bb12742fbfa777fa1947deda21a2

This doesn't explain any of the issues, it just says that they exist.
My best guess would be that at least some of the issue is due to
instantiating the MFD cells from the device tree but it's hard to say
clearly.

I'm guessing Arnd's email answered some of the questions you had. Let me 
know of you would like me to explain it in any greater detail.

By the way, this patch has nothing to do with registering these devices 
when DT is enabled. The code already does that. This is a bug fix, to 
stop multiple registration of the ab8500 when DT is _not_ enabled.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog