[PATCH v5 4/7] arm: omap4: hwmod: introduce emu hwmod
From: paul@pwsan.com (Paul Walmsley)
Date: 2011-11-08 15:26:52
Also in:
linux-omap
Hi some comments On Mon, 24 Oct 2011, ming.lei at canonical.com wrote:
quoted hunk ↗ jump to hunk
From: Ming Lei <redacted> So that access to cross trigger interface can be allowed, which will be introduce in later patches. Signed-off-by: Ming Lei <redacted> --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 26 ++++++++++++++++++++++++++ 1 files changed, 26 insertions(+), 0 deletions(-)diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c index 393afac..c7289a8 100644 --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c@@ -5276,6 +5276,30 @@ static struct omap_hwmod omap44xx_wd_timer3_hwmod = { .slaves_cnt = ARRAY_SIZE(omap44xx_wd_timer3_slaves), }; +static struct omap_hwmod_class omap44xx_emu_hwmod_class = { + .name = "emu", +}; + +static struct omap_hwmod_irq_info omap44xx_emu_irqs[] = { + { .name = "cti0", .irq = 1 + OMAP44XX_IRQ_GIC_START }, + { .name = "cti1", .irq = 2 + OMAP44XX_IRQ_GIC_START }, + { .irq = -1 } +};
Are you sure these are part of the emulation IP? We already have those IRQs in the MPU hwmod, see omap44xx_mpu_irqs[] in the same file.
+/*emu hwmod*/
+static struct omap_hwmod omap44xx_emu_hwmod = {
+ .name = "emu",
+ .class = &omap44xx_emu_hwmod_class,
+ .clkdm_name = "emu_sys_clkdm",
+ .prcm = {
+ .omap4 = {
+ .clkctrl_offs = OMAP4_CM_EMU_CLKSTCTRL_OFFSET,This doesn't look right either: EMU is a clockdomain, not an IP block.
+ .modulemode = MODULEMODE_HWCTRL,
+ },
+ },
+ .mpu_irqs = omap44xx_emu_irqs,
+};
+
static __initdata struct omap_hwmod *omap44xx_hwmods[] = {
/* dmm class */- Paul