[PATCH 3/5] ARM: twd: Add context save restore support

-----Original Message-----
From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
Sent: Tuesday, January 25, 2011 7:08 PM
To: Thomas Gleixner
Cc: Colin Cross; Santosh Shilimkar; catalin.marinas at arm.com;
linus.ml.walleij at gmail.com; linux-omap at vger.kernel.org; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH 3/5] ARM: twd: Add context save restore support

On Tue, Jan 25, 2011 at 02:23:10PM +0100, Thomas Gleixner wrote:

quoted

On Tue, 25 Jan 2011, Russell King - ARM Linux wrote:

[...]

quoted

quoted

The next question is can we teach the generic time

infrastructure about

quoted

quoted

this so we don't have to modify every clock event driver for it?

We

quoted

quoted

really need to get away from having this kind of knowledge

buried down

quoted

quoted

in the lowest levels of every driver.

In which way? I mean the generic code issues a call to the

set_mode

quoted

function when we leave the broadcast mode. So what should the

generic

quoted

code do more ?

I can't say because these patches only add the hooks, there's no
implementation yet which uses the hooks.

Given the description about _why_ those hooks are necessary, it
seems
that something is required.  Either we start adding custom hacks to
each clockevent driver as is done with this patch, or we get some
generic help in place.

I'm not thrilled by the custom hack approach - and I thought the
clockevent stuff was created to stop this kind of thing happening.

I suggest we defer this until there's a visible use case available.

Just for clarification. Without the TWD save restore patch the PM
won't work. So what you mean by visible usecase.
We need this to be fixed and that's what was done with the my
patch. Ofcourse it's a custom hack approach but does the job.

Regards,
Santosh