Thread (113 messages) 113 messages, 27 authors, 8h ago

Re: [PATCH 0/3] vmsplice: make vmsplice a trivial wrapper for preadv2/pwritev2

From: Christian Brauner <brauner@kernel.org>
Date: 2026-06-01 16:17:40
Also in: linux-fsdevel, linux-mm, linux-patches, lkml, netdev

On Mon, Jun 01, 2026 at 08:50:00AM -0700, Linus Torvalds wrote:
On Mon, 1 Jun 2026 at 08:36, Matthew Wilcox [off-list ref] wrote:
quoted
Can we review this series properly?
Well, since it pretty much is what I suggested a few years ago, I
certainly won't NAK it.

And the patches looked very straightforward to me. Just the final
diffstat is worth quoting again because that certainly doesn't look
problematic:

  7 files changed, 33 insertions(+), 204 deletions(-)

and it removes that GIFT flag that was truly disgusting.

So I'm certainly ok with it from a "looking at the patch" standpoint.
I didn't _test_ it. I don't have any workload that might remotely
care.

I did a quick scan on debian code search for vmsplice, and after ten
pages of entries that weren't actually *using* it but had lists of
system calls, I grew bored. So there are likely users, but I don't
know what they are and how much they care. It *might* be a big
performance issue somewhere. Unlikely, but...
As usual I would argue to accept it and revert in case we get actual
regression reports...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help