On Sun, May 31, 2026 at 08:11:34PM -0700, Andy Lutomirski wrote:

On Sat, May 30, 2026 at 6:03 PM Askar Safin [off-list ref] wrote:

quoted

See recent discussion here:
https://lore.kernel.org/all/20260516182126.530498-1-pfalcato@suse.de/T/#u (local)

For all these reasons I propose to make vmsplice a simple wrapper for
preadv2/pwritev2.

I have no comment on the code or the history.  But I'm 100% in favor
of the solution.  vmsplice is a crappy API, and would be incredibly
complex to get the implementation right,  and it should be removed.
But it has users, and the approach of just mapping them straight to
pread/pwrite makes perfect sense.

I agree with Andy.  I think it was appropriate to send this series, since
(as far as I can tell) it's a completely different approach from the others
taken.  I'm not really qualified to judge whether the implementation is
good (it's a bit outside my competency as a reviewer), but the described
approach is more convincing to me than the other approaches.

Can we review this series properly?