On Thu, Feb 01, 2018 at 01:11:07PM +0800, Wu Hao wrote:

On Wed, Jan 31, 2018 at 09:31:59AM -0600, Alan Tull wrote:

quoted

On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao [off-list ref] wrote:

Hi Hao,

One fix again, otherwise please add my ack to subsequent versions.

Sure. Thanks for the review.

quoted

quoted

FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which
need to be supported by all feature devices drivers including FME and AFU.
Userspace application can use these ioctl interfaces to get the API info
and check if specific extension is supported or not in current driver.

This patch implements above 2 ioctls in FPGA Management Engine (FME)
driver.

Signed-off-by: Tim Whisonant <redacted>
Signed-off-by: Enno Luebbers <redacted>
Signed-off-by: Shiva Rao <redacted>
Signed-off-by: Christopher Rauer <redacted>
Signed-off-by: Xiao Guangrong <redacted>
Signed-off-by: Wu Hao <redacted>

Acked-by: Alan Tull <atull@kernel.org>

Acked-by: Moritz Fischer <mdf@kernel.org>

quoted

quoted

diff --git a/include/uapi/linux/fpga-dfl.h b/include/uapi/linux/fpga-dfl.h
new file mode 100644
index 0000000..b46d124
--- /dev/null
+++ b/include/uapi/linux/fpga-dfl.h

@@ -0,0 +1,50 @@
+/*
+ * Header File for FPGA DFL User API
+ *
+ * Copyright (C) 2017 Intel Corporation, Inc.
+ *
+ * Authors:
+ *   Kang Luwei <luwei.kang@intel.com>
+ *   Zhang Yi <yi.z.zhang@intel.com>
+ *   Wu Hao <hao.wu@intel.com>
+ *   Xiao Guangrong <guangrong.xiao@linux.intel.com>
+ *
+ * This work is licensed under the terms of the GNU GPL version 2.

Please remove above line.  My understanding is that we are supposed to
not combine SPDX with other license statements.

quoted

+ * SPDX-License-Identifier: GPL-2.0
+ */

// SPDX-License-Identifier: GPL-2.0

As first line of file.

Sure, I will fix this in the next version.

Thanks
Hao

quoted

Thanks,
Alan

Thanks,

Moritz