Re: [PATCH v3 03/21] fpga: mgr: add status for fpga-manager
From: Wu Hao <hidden>
Date: 2017-12-05 04:18:03
Also in:
linux-fpga, lkml
From: Wu Hao <hidden>
Date: 2017-12-05 04:18:03
Also in:
linux-fpga, lkml
On Mon, Dec 04, 2017 at 02:55:42PM -0600, Alan Tull wrote:
On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao [off-list ref] wrote: Hi Hao, mgr->status isn't used anywhere except in status_show. So we don't need to add status to the fpga_manager struct. Also don't need the inline function to update it. Just read the status in status_show, if that ops exists. If mops->status is NULL, return an error, as below. This will simplify things and make sure that status_show gets status that is not stale at all.
Hi Alan You're right, this is much simpler. Will follow this to fix it in the next version. Thanks! Hao