Thread (53 messages) 53 messages, 5 authors, 2014-06-27

Re: [PATCH v8 3/9] seccomp: introduce writer locking

From: Oleg Nesterov <oleg@redhat.com>
Date: 2014-06-25 14:05:51
Also in: linux-arch, linux-arm-kernel, linux-mips, lkml 

On 06/24, Kees Cook wrote:
quoted hunk ↗ jump to hunk
@@ -524,6 +529,8 @@ static long seccomp_set_mode(unsigned long seccomp_mode, char __user *filter)
 	}
 #endif

+	spin_lock_irqsave(&current->sighand->siglock, irqflags);
+
Well, I won't argue if you prefer to use _irqsave "just in case".

But irqs must be enabled in syscall paths, you could use spin_lock_irq().
The same for seccomp_set_mode_filter() added later.

Oleg.
  



    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help