Thread (1333 messages) 1333 messages, 109 authors, 2024-01-05

Re: GPU-DRM-TTM: Fine-tuning for several function implementations

From: SF Markus Elfring <hidden>
Date: 2016-09-23 11:49:38
Also in: dri-devel, lkml

Calling the label "unlock" instead of "out" is arguable a little better,
Thanks that you can follow a renaming for this direction in principle.

but nothing I would call a major improvement either.
This was not my intention for such an use case.

I am proposing some small software updates according to such a design pattern.

So that is a clear NAK to all those patches.
Do you reject also update steps like the following then?

* drm/ttm: Use kmalloc_array() in two (or four?) functions"

* drm/ttm: Less function calls in ttm_dma_pool_init() after error detection

* Would you like to improve the usage of the variables "n" and "t"
  in the function "ttm_dma_pool_init" any further as Joe Perches suggested it?

quoted
2. How do you think about to add a single space character before any label?
Bad as well. Why would anybody want to do this?
Do you find another software evolution interesting according to a recent commit?

"docs: Remove space-before-label guidance from CodingStyle"
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?idyc70c304b0b443429b2a0019518532c5162817a


Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help