Thread (1333 messages) 1333 messages, 109 authors, 2024-01-05

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

From: SF Markus Elfring <hidden>
Date: 2016-09-04 05:01:50
Also in: lkml, sparclinux

Does this change improve the resulting binary?
I hope so. - I propose to give the refactorings "Reduce scope of variable"
and "Extract a function" (and the corresponding consequences) another look.

I.e. does it make it smaller or faster?
It is generally possible that a specific code generation variant will also affect
the run time properties you mentioned.

Otherwise this change is useless churn - you're making the code more
complicated, longer and harder to read for practically no benefit.
I imagine that there other reasons you could eventually accept
for this use case, aren't there?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help