Re: [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_tab
From: Dan Carpenter <hidden>
Date: 2016-01-15 10:30:14
Also in:
lkml, netdev
From: Dan Carpenter <hidden>
Date: 2016-01-15 10:30:14
Also in:
lkml, netdev
On Fri, Jan 15, 2016 at 11:12:42AM +0100, SF Markus Elfring wrote:
From: Markus Elfring <redacted> Date: Fri, 15 Jan 2016 10:40:24 +0100 Omit explicit initialisation at the beginning for four local variables which are redefined before their first use. Signed-off-by: Markus Elfring <redacted> --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index 825b051..8302f7d 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c@@ -768,12 +768,12 @@ static void ethflow_to_filer_rules (struct gfar_private *priv, u64 ethflow) static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, u64 class) { - unsigned int last_rule_idx = priv->cur_filer_idx; + unsigned int last_rule_idx;
This is a write only variable. We can just remove it. regards, dan carpenter