Thread (171 messages) flat view 171 messages, 9 authors, 1d ago

Re: [PATCH v13 7/8] history: create squashed commits without editing

From: Kristoffer Haugsbakk <hidden>
Date: 2026-08-17 20:08:17

On Mon, Aug 17, 2026, at 19:38, Harald Nordgren wrote:
quoted
 >> Inspired-by: Sergey Chernov [off-list ref]
 >> Helped-by: Phillip Wood [off-list ref]
 >> Signed-off-by: Harald Nordgren [off-list ref]

Thanks for the Helped-by: trailer, but this and several of the other
patches are missing my sign off from the fixup patches I sent. My sign
off should come above yours to reflect the chain of custody.
Got it, should I use both headers?

    Helped-by: Phillip Wood [off-list ref]
    Signed-off-by: Phillip Wood [off-list ref]
    Signed-off-by: Harald Nordgren [off-list ref]
In general swapping the first and second makes more sense.

    S: PW
    H: PW
    S: HN

Because as a chain of custody this says: Phillip
signed off, then Harald said that PW helped him,
then Harald signed off on what he got from PW
with perhaps his own changes mixed in.

sent from mobile
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help