Thread (67 messages) 67 messages, 7 authors, 12h ago

Re: [PATCH v6 4/4] history: re-edit a squash with every message

From: Junio C Hamano <hidden>
Date: 2026-06-29 17:38:07

Junio C Hamano [off-list ref] writes:
Harald Nordgren [off-list ref] writes:
quoted
quoted
I doubt it would make practical difference, but one thing I notice
is that unlike "git rebase -i", this one does not intersperse
markers like "# This is the 1st commit message" in between the
messages taken from the squashed commits, so it is not exactly
"mirroring".
I wouldn't mind extracting that logic from 'rebase -i' to show it
here. It would be nice to have.
If we can share more code (not necessarily the exact existing
code---after cleaning it up if needed is perfectly fine and may even
be better) across codebaes that would be excellent.  Thanks.
After looking at what Phillip said in a side thread (look for "So
instead of ... We'd have") [*], I retract my "I doubt it would make
practical difference".  Without boundary that shows where each
message begins, the result is much harder to look at.


[Reference]

 * https://lore.kernel.org/git/3b3af3ef-a043-4af9-964e-429237789c97@gmail.com/ (local)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help