Thread (115 messages) 115 messages, 7 authors, 7d ago

Re: [PATCH v7 0/5] history: add squash subcommand to fold a range

From: Harald Nordgren <hidden>
Date: 2026-07-07 08:56:18

quoted
The range-diff does not show any input sanitization - what happens when
the user passes "--reverse" for example? As I said in [4] we should copy
what "git replay" does to sanity check the rev-list options, otherwise
we've got no idea whether the parent of the first commit returned by
get_revision() is the commit we want to use as the parent of the
squashed commit.
Yeah, good point.
Well, the code already blocks "--reverse" and other unknown options,
but I can clarify that better in the commit message.


Harald
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help