Thread (159 messages) flat view 159 messages, 7 authors, 3d ago

Re: [PATCH v7 07/10] commit-reach: introduce struct paint_state with per-side counters

From: Kristofer Karlsson <hidden>
Date: 2026-08-07 16:01:08

On Fri, 7 Aug 2026 at 17:44, Elijah Newren [off-list ref] wrote:

My comment was meant more as a "review out loud; show how I'm thinking
about the patch as I read it" kind of comment rather than as a note of
something worth changing in the patch.  The order _is_ important here,
so the idea of adding a comment to reinforce it seems quite reasonable
to consider (I thought about changing my comment to ask for one when
reviewing), but I'm on the fence about whether it's important enough
or overkill.  I'm okay with the patch either way.
True, but your thinking out loud fortunately reminded me that I had
the same thought process, and that the ordering may not be
immediately obvious -- and thus we should document it.

I will add a comment for it...
Although, if you do add one, as per the CodingGuidelines:

/*
 * Multi-line comments include their delimiters
 * on separate lines from the text.
 */

:-)
... and I will be stricter about the formatting in the patches
than I was in the email :)

Thanks,
Kristofer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help