Thread (125 messages) 125 messages, 7 authors, 4d ago

Re: [PATCH v3 7/8] commit-reach: terminate merge-base walk when one paint side is exhausted

From: Kristofer Karlsson <hidden>
Date: 2026-06-26 14:29:24

On Fri, 26 Jun 2026 at 15:08, Kristofer Karlsson via GitGitGadget
[off-list ref] wrote:
From: Kristofer Karlsson <redacted>

-               if (min_generation && generation > last_gen)
+               if (generation > last_gen)
I have to note that I accidentally pushed this version before noticing
that it now fails for a subset of commit-graph modes.
Apologies for that - I will rework the logic here later
to preserve the behavior better.

I think (and hope) the rest of the patch series is in good shape though
and addressed the previous feedback, so any partial new review
feedback would still be appreciated.

Thanks,
Kristofer
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help