Re: [PATCH v3 4/8] commit-reach: add trace2 instrumentation to paint_down_to_common()

On Fri, 26 Jun 2026 at 16:31, Derrick Stolee [off-list ref] wrote:

quoted

 test_expect_success 'ref_newer:miss' '
      cat >input <<-\EOF &&
      A:commit-5-7

@@ -209,7 +219,8 @@ test_expect_success 'in_merge_bases_many:self' '
      X:commit-6-8
      EOF
      echo "in_merge_bases_many(A,X):1" >expect &&
-     test_all_modes in_merge_bases_many
+     test_all_modes in_merge_bases_many &&
+     test_paint_down_steps 45 2 25 3
 '

oooh that's clean. Thanks!

Way to over-achieve here. Thanks for going the extra mile with
this patch.

Thanks! I did not want to change it too much but this felt like
a natural place to simplify it a bit.

I also have a local branch now for adding a
test_trace2_data_singular helper function that provides
more diagnostics on failures
(show expected vs actual similar to test_cmp)
but I'll submit that separately later to limit the scope creep here.

Thanks,
Kristofer