Thread (183 messages) 183 messages, 9 authors, 2022-06-11

Re: [PATCH v4 0/5] unpack large objects in stream

From: Derrick Stolee <hidden>
Date: 2021-12-07 16:18:11

On 12/3/2021 4:35 AM, Han Xin wrote:
From: Han Xin <redacted>

Changes since v3:
* Add "size" to "struct input_stream" which used by following commits.

* Increase the buffer size of "struct input_zstream_data" from 4096 to
  8192, which is consistent with the "fixed_buf" in the "index-pack.c".

* Refactor "read stream in a loop in write_loose_object()" which
  introduced a performance problem reported by Derrick Stolee[1].
Thank you for finding the issue. It seems simple enough to add that size
information and regain the performance back to nearly no overhead. Your
hyperfine statistics are within noise, which is great. Thanks!

-Stolee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help