On 12/2/2021 2:33 AM, Han Xin wrote:

On Wed, Dec 1, 2021 at 2:38 AM Derrick Stolee [off-list ref] wrote:

quoted

These pack-files contain (mostly) small objects, no large blobs.
I know that's not the target of your efforts, but it would be
good to avoid a regression here.

Thanks,
-Stolee

With your help, I did catch this performance problem, which was
introduced in this patch:
https://lore.kernel.org/git/20211122033220.32883-4-chiyutianyi@gmail.com/ (local)

This patch changes the original data reading ino to stream reading, but
its problem is that even for the original reading of the whole object data,
it still generates an additional git_deflate() and subsequent transfer.

I'm glad you found it!

I will fix it in a follow-up patch.

Looking forward to it.

Thanks,
-Stolee