Thread (183 messages) 183 messages, 9 authors, 2022-06-11

Re: [PATCH v4 4/5] unpack-objects.c: add dry_run mode for get_data()

From: Han Xin <hidden>
Date: 2021-12-06 03:20:37

On Fri, Dec 3, 2021 at 10:00 PM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

On Fri, Dec 03 2021, Han Xin wrote:
quoted
+     unsigned long bufsize = dry_run ? 4096 : size;
+     void *buf = xmallocz(bufsize);
It's probably nothing, but in your CL you note that you changed another
hardcoding from 4k to 8k, should this one still be 4k?

It's probably fine, just wondering...
Yes, I think this is an omission from my work.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help